On Fri, 2019-06-14 at 16:56 +0900, Alexandre Courbot wrote: > We were getting the codec interface through a proxy function that does > not bring anything compared to just accessing the interface definition > directly, so just do that. Also make the decoder interfaces const. [] > diff --git a/drivers/media/platform/mtk-vcodec/vdec/vdec_h264_if.c b/drivers/media/platform/mtk-vcodec/vdec/vdec_h264_if.c [] > @@ -485,16 +485,9 @@ static int vdec_h264_get_param(void *h_vdec, enum vdec_get_param_type type, > return 0; > } > > -static struct vdec_common_if vdec_h264_if = { > +const struct vdec_common_if vdec_h264_if = { probably better to fixup whatever chains prevent this (if any) from being static const > .init = vdec_h264_init, > .decode = vdec_h264_decode, > .get_param = vdec_h264_get_param, > .deinit = vdec_h264_deinit, > };