Re: [Fwd: [Mjpeg-users] [PATCH] zoran: match parameter signedness of g_input_status]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bernhard (& Marton),

patch is OK with me, you can forward this to LKML, or better yet, to
the V4L maintainers (this is try#2 to CC them).

Cheers,
Ronald

2010/1/29 Bernhard Praschinger <shadowlord@xxxxxxxxx>:
> Hallo
>
> I hope that you got the mail to the mailinglist to. Can you please check it
> and approve it or do something else with it ;)
>
>
>
> auf hoffentlich bald,
>
> Berni the Chaos of Woodquarter
>
> Email: shadowlord@xxxxxxxxx
> www: http://www.lysator.liu.se/~gz/bernhard
>
> From: Márton Németh <nm127@xxxxxxxxxxx>
>
> The second parameter of g_input_status operation in <media/v4l2-subdev.h>
> is unsigned so also call it with unsigned paramter.
>
> This will remove the following sparse warning (see "make C=1"):
>  * incorrect type in argument 2 (different signedness)
>       expected unsigned int [usertype] *status
>       got int *<noident>
>
> Signed-off-by: Márton Németh <nm127@xxxxxxxxxxx>
> ---
> diff -r 2a50a0a1c951 linux/drivers/media/video/zoran/zoran_device.c
> --- a/linux/drivers/media/video/zoran/zoran_device.c    Sat Jan 23 00:14:32
> 2010 -0200
> +++ b/linux/drivers/media/video/zoran/zoran_device.c    Sat Jan 23 07:57:09
> 2010 +0100
> @@ -1197,7 +1197,8 @@
>  static void zoran_restart(struct zoran *zr)
>  {
>        /* Now the stat_comm buffer is ready for restart */
> -       int status = 0, mode;
> +       unsigned int status = 0;
> +       int mode;
>
>        if (zr->codec_mode == BUZ_MODE_MOTION_COMPRESS) {
>                decoder_call(zr, video, g_input_status, &status);
> diff -r 2a50a0a1c951 linux/drivers/media/video/zoran/zoran_driver.c
> --- a/linux/drivers/media/video/zoran/zoran_driver.c    Sat Jan 23 00:14:32
> 2010 -0200
> +++ b/linux/drivers/media/video/zoran/zoran_driver.c    Sat Jan 23 07:57:09
> 2010 +0100
> @@ -1452,7 +1452,7 @@
>        }
>
>        if (norm == V4L2_STD_ALL) {
> -               int status = 0;
> +               unsigned int status = 0;
>                v4l2_std_id std = 0;
>
>                decoder_call(zr, video, querystd, &std);
>
>
> ------------------------------------------------------------------------------
> Throughout its 18-year history, RSA Conference consistently attracts the
> world's best and brightest in the field, creating opportunities for
> Conference
> attendees to learn about information security's most important issues
> through
> interactions with peers, luminaries and emerging and established companies.
> http://p.sf.net/sfu/rsaconf-dev2dev
> _______________________________________________
> Mjpeg-users mailing list
> Mjpeg-users@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/mjpeg-users
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux