On Wed, Jun 12, 2019 at 12:05 PM YueHaibing <yuehaibing@xxxxxxxxxx> wrote: > > Fix building error: > > drivers/staging/media/meson/vdec/vdec.c: In function vdec_recycle_thread: > drivers/staging/media/meson/vdec/vdec.c:59:10: error: implicit declaration > of function kthread_should_stop; > did you mean thread_saved_sp? [-Werror=implicit-function-declaration] > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Fixes: 3e7f51bd9607 ("media: meson: add v4l2 m2m video decoder driver") > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > --- > drivers/staging/media/meson/vdec/vdec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c > index 4e4f9d6..0a1a04f 100644 > --- a/drivers/staging/media/meson/vdec/vdec.c > +++ b/drivers/staging/media/meson/vdec/vdec.c > @@ -12,6 +12,7 @@ > #include <linux/mfd/syscon.h> > #include <linux/slab.h> > #include <linux/interrupt.h> > +#include <linux/kthread.h> > #include <media/v4l2-ioctl.h> > #include <media/v4l2-event.h> > #include <media/v4l2-ctrls.h> > -- > 2.7.4 > > Thanks for the patch, sorry that this one slipped through. Acked-by: Maxime Jourdan <mjourdan@xxxxxxxxxxxx>