On Wed, 2019-06-12 at 10:00 +0200, Hans Verkuil wrote:
> On 6/12/19 9:55 AM, Hans Verkuil wrote:
> > On 6/11/19 2:50 PM, Philipp Zabel wrote:
> > > There are several other SoCs that contain Hantro IP based VPUs, such as
> > > NXP i.MX8MQ (Hantro G1 and G2) and i.MX8MM (Hantro G1, G2, and H1). To
> > > maximize code sharing, add initial support for these SoCs to the
> > > Rockchip VPU driver, after renaming it to Hantro VPU.
> > >
> > > This series is based on the br-v5.3g tag, commit e568d2cc1ef6
> > > ("rockchip/vpu: Add support for MPEG-2 decoding on RK3288") with
> > > https://patchwork.linuxtv.org/patch/56402/ ("rockchip/vpu: Add support
> > > for MPEG-2 decoding on RK3328") applied on top. It supports MPEG-2
> > > decoding on i.MX8MQ. MPEG-2 decoding and JPEG encoding on i.MX8MM may
> > > or may not work, I don't have the hardware to test.
> > >
> > > Changes since v3:
> > > - Split rk3288_vpu_regs.h into hantro_g1_regs.h and hantro_h1_regs.h,
> > > rename VDPU register defines to G1 and VEPU register defines to H1.
> > > - Make Rockchip / i.MX8M support configurable.
> > > - Keep staging/media Kconfig in alphabetic order.
> > > - Rename bases to reg_bases
> > > - Move dynamic clocks before i.MX8M support.
> >
> > Can you please rebase this on top of the media_tree master? This series
> > doesn't apply there.
> >
> > I'd like to get this rename series in asap since keeping this out-of-tree
> > is a pain.
> >
> > It looks in good shape in general.
>
> In fact, I would like to hold off on applying any other rockchip patches
> until this is in (and that means any pending rockchip patches probably
> need rebasing).
>
> So if a v5 applies cleanly and doesn't throw up new sparse/smatch issues,
> then I'll take it.
I've rebased onto media-tree master, checked sparse/smatch, and resent.
The RK3328 patch is pulled out from under it and sent separately on top
of the series.
regards
Philipp
