On 6/10/19 5:48 AM, Tomasz Figa wrote: > Hi Maxime, > > On Sun, Jun 9, 2019 at 11:38 PM Maxime Jourdan <mjourdan@xxxxxxxxxxxx> wrote: >> >> Add a enum_fmt format flag to specifically tag coded formats where >> dynamic resolution switching is supported by the device. >> >> This is useful for some codec drivers that can't support dynamic >> resolution switching for all their listed coded formats. It allows >> userspace to know whether it should extract the video parameters itself, >> or if it can rely on the device to send V4L2_EVENT_SOURCE_CHANGE when >> such changes are detected. >> > > First of all, thanks for the patch! > > Given the aspect of compatibility and also the general preference for > the drivers to actually handle dynamic resolution changes, I'd suggest > inverting the meaning of this flag. With something like > "V4L2_FMT_FLAG_STATIC_RESOLUTION" it would be more of an exception > rather than the default behavior. We had a discussion about that, see this thread: https://lkml.org/lkml/2019/5/31/256 Regards, Hans
