On Thu, 6 Jun 2019 12:44:21 -0300 Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx> wrote: > Hi, > > This patchset introduces a new vb2_get_buffer accessor and then > uses it on all the drivers that are accessing videobuf2 > private buffer array directly. Just curious, how did you find all occurrences of direct q->bufs[] accesses? If you used a cocci script it might be worth submitting it so we don't end up with new offenders of the "don't access q->bufs[] directly" rule. > > I'm skipping Intel IPU3 driver here, since the code goes beyond > just accessing the buffer. It also modifies the buffer queue > directly. I believe this driver would need some more cleanup > and love from its maintainers. > > Note that OMAP2/OMAP3 display driver is videobuf1 and so not > affected by this change. > > Lastly, note that I'm doing the minimum changes to drivers I can't test, > only using the new accessor and avoiding any further changes. Can you also add a patch to remove the private buf pointers array in the cedrus driver? > ` > Thanks, > Ezequiel > > Ezequiel Garcia (5): > media: vb2: Introduce a vb2_get_buffer accessor > media: mtk-jpeg: Use vb2_get_buffer > media: mtk-vcodec: Use vb2_get_buffer > media: sti: Use vb2_get_buffer > media: rockchip: Use vb2_get_buffer > > .../media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 +- > .../media/platform/mtk-vcodec/mtk_vcodec_enc.c | 12 +++++++++--- > drivers/media/platform/sti/hva/hva-v4l2.c | 4 +++- > .../media/rockchip/vpu/rockchip_vpu_drv.c | 9 ++++++--- > include/media/videobuf2-core.h | 18 ++++++++++++++++++ > 5 files changed, 37 insertions(+), 8 deletions(-) >
