Re: [PATCH RFC 5/6] media: cedrus: Make the slice_params array size limitation more explicit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le lundi 03 juin 2019 à 23:48 +0200, Jernej Škrabec a écrit :
> Dne ponedeljek, 03. junij 2019 ob 13:09:45 CEST je Boris Brezillon napisal(a):
> > The driver only supports per-slice decoding, and in that mode
> > decode_params->num_slices must be set to 1 and the slice_params array
> > should contain only one element.
> 
> What Cedrus actually needs to know is if this is first slice in frame or not. I 
> imagine it resets some stuff internally when first slice is processed.
> 
> So if driver won't get all slices of one frame at once, it can't know if this 
> is first slice in frame or not. I guess we need additional flag for this.

A first slice of a frame comes with a new timestamp, so you don't need
a flag for that.

regards,
Nicolas

> 
> Best regards,
> Jernej
> 
> > The current code already had this limitation but it made it look like
> > the slice_params control was a single struct while, according to the
> > spec, it's actually an array. Make it more explicit by setting dims[0]
> > and adding a comment explaining why we have this limitation.
> > 
> > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> 
> 




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux