Hi Jacopo, On Mon, May 27, 2019 at 06:44:41PM +0200, Jacopo Mondi wrote: > Hi Sakari, > > On Fri, Mar 01, 2019 at 01:23:57PM +0200, Sakari Ailus wrote: > > Address a compiler warnings on alignment of struct ipu3_uapi_awb_fr_config_s > > by adding __attribute__((aligned(32))) to a struct member of that type as > > well. > > > > Sorry, just noticed there was a v2. > > This is how we momentary worked it around in libcamera, so my tag on > v1 also applies here too :) > > Could I know why this is preferred compared to v1? Has the field to be > actually 32 bytes aligned? Not because of IPU3 DMA, but to maintain ABI compatibility. Technically there's no strict need to do that as this is a staging driver. This patch simply fixes the warning. Later on it'd be good to remove the alignment where they are unnecessary. -- Regards, Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
