On 5/28/19 5:00 PM, Michael Tretter wrote: > On Tue, 28 May 2019 15:54:58 +0200, Hans Verkuil wrote: >> Hi Michael, >> >> On 5/28/19 3:09 PM, Michael Tretter wrote: >>> This is v7 of the Allegro DVT H.264 encoder driver found in the EV >>> family of the Xilinx ZynqMP platform. >>> >>> I moved the driver back to staging, because the v4l2 stateful encoder spec is >>> not finished, yet. Once the spec is finished, this driver shall be tested >>> against the final v4l2-compliance and moved to mainline again. >>> >>> Further, I converted the allegro vendor prefix to the new json format in >>> vendor-prefixes.yaml. >>> >>> The observed occasional failures in v4l2-compliance in v6 of this series >>> turned out to be caused by a race condition with v4l2_m2m_poll(). I will send >>> patches to fix this issue as a separate series. >> >> I'm getting these smatch warnings: >> >> drivers/staging/media/allegro-dvt/allegro-core.c:1849:36: warning: constant 0xffffffff00000000 is so big it is unsigned long > > The constant is used to calculate an offset, which is used by the > hardware as offset for addresses in mailbox messages. The hardware > expects a 64 bit value, but the driver calculates the value using a > dma_addr_t, which is fine for 64 bit systems (e.g. ZynqMP), but is a > problem on 32 bit systems. > > I am currently working on improving the handling of frame addresses and > make it fit for using the PL-RAM (in the FPGA) instead of the normal > system RAM (PS-RAM). I would fix the warning with that patch set, if > it is OK. Sorry, no. I don't want new drivers creating new warnings. It's OK to do a quick workaround and fix it properly later, though. Regards, Hans > >> drivers/staging/media/allegro-dvt/nal-h264.c:751: warning: Function parameter or member 'dev' not described in 'nal_h264_write_sps' >> drivers/staging/media/allegro-dvt/nal-h264.c:792: warning: Function parameter or member 'dev' not described in 'nal_h264_read_sps' >> drivers/staging/media/allegro-dvt/nal-h264.c:842: warning: Function parameter or member 'dev' not described in 'nal_h264_write_pps' >> drivers/staging/media/allegro-dvt/nal-h264.c:884: warning: Function parameter or member 'dev' not described in 'nal_h264_read_pps' >> drivers/staging/media/allegro-dvt/nal-h264.c:926: warning: Function parameter or member 'dev' not described in 'nal_h264_write_filler' >> drivers/staging/media/allegro-dvt/nal-h264.c:969: warning: Function parameter or member 'dev' not described in 'nal_h264_read_filler' > > I didn't describe the "struct device *dev" parameter, because it really > doesn't add any value. > > Michael > >> >> Can you take a look? The nal-h264.c warnings look trivial to fix, the >> allegro-core.c warnings looks more interesting. >> >> Regards, >> >> Hans >>
