On 5/28/19 12:16 PM, Naresh Kamboju wrote: > Hi Hans, > > On Mon, 20 May 2019 at 19:26, Naresh Kamboju <naresh.kamboju@xxxxxxxxxx> wrote: >> >> Hi Hans, >> >> On Mon, 13 May 2019 at 19:08, Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote: >>> >>> On 5/13/19 3:32 PM, Naresh Kamboju wrote: >>>> Do you see test VIDIOC_G/S_PARM: FAIL on stable 4.14, 4.9 and 4.4 >>>> kernel branches ? >>> >>> Probably related to commit 8a7c5594c0202 (media: v4l2-ioctl: clear fields in s_parm). >> >> I have cherry-picked on stable rc 4.9 branch and tested and test got >> PASS on x86_64. > > I have cherry-picked for stable -rc 4.14 and 4.9 and test got PASS. Just to be clear: you cherry-picked commit 8a7c5594c0202 (media: v4l2-ioctl: clear fields in s_parm) for both 4.9 and 4.14, right? If so, feel free to post that patch to the stable mailinglist for those kernels. Make sure you CC me when you do that. > > do you want to queue this for stable rc 4.14 and 4.9 ? > > I have tested for 4.4 with patch applied but failed with below error. > > test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK > warn: ../../../v4l-utils-1.16.0/utils/v4l2-compliance/v4l2-test-formats.cpp(1237): > S_PARM is supported but doesn't report V4L2_CAP_TIMEPERFRAME > fail: ../../../v4l-utils-1.16.0/utils/v4l2-compliance/v4l2-test-formats.cpp(1139): > node->has_frmintervals && !cap->capability > test VIDIOC_G/S_PARM: FAIL You probably need commit f63998331935 ([media] vivid: set V4L2_CAP_TIMEPERFRAME) and possibly commit 3f122df4a2ba (media: vivid: do not implement VIDIOC_S_PARM for output streams). Regards, Hans > > 4.4 - failed log > https://lkft.validation.linaro.org/scheduler/job/746548#L1678 > > ref: > 4.14 pass log, > https://lkft.validation.linaro.org/scheduler/job/739126#L1843 > > 4.9 pass log, > https://lkft.validation.linaro.org/scheduler/job/736243#L1744 > > - Naresh >
