On Mon, May 27, 2019 at 11:11:32AM +0200, Hans Verkuil wrote: > The reserved field array for struct media_link_desc has length 2, not 4. > > And the reserved field array of struct media_links_enum was never documented > at all. > > Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > --- > diff --git a/Documentation/media/uapi/mediactl/media-ioc-enum-links.rst b/Documentation/media/uapi/mediactl/media-ioc-enum-links.rst > index a982f16e55a4..b827ebc398f8 100644 > --- a/Documentation/media/uapi/mediactl/media-ioc-enum-links.rst > +++ b/Documentation/media/uapi/mediactl/media-ioc-enum-links.rst > @@ -84,6 +84,11 @@ returned during the enumeration process. > - Pointer to a links array allocated by the application. Ignored if > NULL. > > + * - __u32 > + - ``reserved[4]`` > + - Reserved for future extensions. Drivers and applications must set > + the array to zero. > + > > .. c:type:: media_pad_desc > > @@ -135,7 +140,7 @@ returned during the enumeration process. > - Link flags, see :ref:`media-link-flag` for more details. > > * - __u32 > - - ``reserved[4]`` > + - ``reserved[2]`` > - Reserved for future extensions. Drivers and applications must set > the array to zero. > -- Sakari Ailus