On Thu, 2019-05-02 at 19:00 -0300, Ezequiel Garcia wrote: > While working on a SoC with CODA980 (currently not supported by the > driver), I came across some low-hanging fruit that looked worth > addressing. > > Patch 1 is just a cosmetic change to print a different "more standard" > device registered message, if such thing exists. > > Patches 2 and 3 address unneeded usage of a threaded interrupt. > Careful code inspection shows the interrupt can be serviced > on a normal handler. > > Finally, patch 4 clears a hardware register called INT_REASON. > Without this clearing the firmware has been found to get stuck > on our CODA980. I believe this fix might be useful to carry upstream, > because it's so small and we have some indications that it's actually > the right thing to do. > > Not much has changed in this series, compared to v1. > > v2: > > * Add R-B by Philip. > * Drop the worker removal patch, which is a controversial change. > * Use video_device_node_name as suggested by Hans. > > Ezequiel Garcia (4): > media: coda: Print a nicer device registered message > media: coda: Remove unbalanced and unneeded mutex unlock > media: coda: Replace the threaded interrupt with a hard interrupt > media: coda: Clear the interrupt reason > > drivers/media/platform/coda/coda-bit.c | 2 +- > drivers/media/platform/coda/coda-common.c | 17 +++++++++++------ > 2 files changed, 12 insertions(+), 7 deletions(-) > Hi Hans, Any other feedback on these? Thanks, Ezequiel
