On Thu, May 16, 2019 at 09:27:03AM +0200, Geert Uytterhoeven wrote: > On Thu, May 16, 2019 at 3:49 AM Niklas Söderlund wrote: > > Runtime PM is already enabled unconditionally when the driver is probed > > and disabled when it's removed. There is no point in doing it again for > > Gen2 when opening and closing the video device. > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > > Reviewed-by: Ulrich Hecht <uli+renesas@xxxxxxxx> > > --- > > drivers/media/platform/rcar-vin/rcar-v4l2.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c > > index b821ea01786eb1ff..0841f1a0bfd7ba3a 100644 > > --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c > > +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c > > @@ -797,8 +797,6 @@ static int rvin_initialize_device(struct file *file) > > if (ret < 0) > > return ret; > > > > - pm_runtime_enable(&vin->vdev.dev); > > Ah, this already (partly) answers my question on patch 1/8. Note that those are two different devices, here we enable runtime PM in the V4L2 video node class device, while at probe time we enable it on the platform device. I agree that this call should go, but that's only because all runtime PM calls on the class device should go :-) > > > - > > /* > > * Try to configure with default parameters. Notice: this is the > > * very first open, so, we cannot race against other calls, -- Regards, Laurent Pinchart
