Hi Niklas, Thank you for the patch. On Thu, May 16, 2019 at 03:14:12AM +0200, Niklas Söderlund wrote: > The user should be allowed to break waiting for the lock when opening > the video device. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > Reviewed-by: Ulrich Hecht <uli+renesas@xxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/media/platform/rcar-vin/rcar-v4l2.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c > index 0841f1a0bfd7ba3a..f67cef97b89a3bd4 100644 > --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c > +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c > @@ -821,7 +821,9 @@ static int rvin_open(struct file *file) > struct rvin_dev *vin = video_drvdata(file); > int ret; > > - mutex_lock(&vin->lock); > + ret = mutex_lock_interruptible(&vin->lock); > + if (ret) > + return ret; > > file->private_data = vin; > -- Regards, Laurent Pinchart
