Hi Maxime, On Tue, May 14, 2019 at 3:56 PM Maxime Jourdan <mjourdan@xxxxxxxxxxxx> wrote: > > Add documentation for the meson vdec dts node. thank you for working on this! > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Maxime Jourdan <mjourdan@xxxxxxxxxxxx> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> [...] > +Required properties: > +- compatible: value should be different for each SoC family as : > + - GXBB (S905) : "amlogic,gxbb-vdec" > + - GXL (S905X, S905D) : "amlogic,gxl-vdec" > + - GXM (S912) : "amlogic,gxm-vdec" > +- reg: base address and size of he following memory-mapped regions : > + - dos > + - esparser > +- reg-names: should contain the names of the previous memory regions > +- interrupts: should contain the following IRQs: > + - vdec > + - esparser > +- interrupt-names: should contain the names of the previous interrupts Maxime already mentioned in the RFC version that there may be more interrupts in the future. I'm fine with adding the missing ones on demand > +- amlogic,ao-sysctrl: should point to the AOBUS sysctrl node my goal is to remove this property at some point and replace it with references to the power-domains. however, we don't have a power-domain driver for this yet (it's somewhere on my TODO-list - it involves splitting the current meson-gx-pwrc-vpu into two separate drivers, so we need to do it carefully so we don't break HDMI support) Regards Martin
