On Sat, May 11, 2019 at 12:10:30PM +0200, Janusz Krzysztofik wrote: > +static int check_get_fmt(struct v4l2_subdev *sd, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_format *format) > +{ > + return check_format(sd, format) ? : > + sd->ops->pad->get_fmt(sd, cfg, format); On naming --- when you're actually calling the function that does the job, I'd call the wrapper e.g. call_something() instead. The current naming suggests that only checks are being made. -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx