Re: [PATCH v4 0/8] Switch to sync registration for IPU subdevs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 5/10/19 9:43 AM, Steve Longerbeam wrote:


On 5/10/19 4:18 AM, Hans Verkuil wrote:
On 5/6/19 11:16 PM, Rui Miguel Silva wrote:
Hi Steve,
On Fri 03 May 2019 at 23:43, Steve Longerbeam wrote:
Switch to sync registration for the IPU internal sub-devices, re-organize
modules, and a few other miscellaneous cleanups.
Thanks for the series and the fixes. Now everything works as
before. So, for the all series and related to imx7:

Tested-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx>
Reviewed-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx>

My only concern is that Hans already pull requested to v5.2 [0] my
previous patch that your series do not apply on top of.

So, @Hans will you push this series to v5.2 and add a revert
of [1]? or this will go only to v5.3?
This will only go to v5.3.

I believe that Mauro plans to get [0] into 5.2, probably as a pull request once v5.2-rc1 has been released. So once that is merged Steve probably needs
to do a rebase of this series.

The imx6 subdevs don't hold a reference to the media device any longer with this series, so [0] will need to be reverted. I will do that in the next version.

Sorry [1] below will need to be reverted.

Steve





[0]: https://lore.kernel.org/linux-media/d5b4a68d-520e-0e93-d44e-07974058d690@xxxxxxxxx/ [1]: https://lore.kernel.org/linux-media/20190412164400.1270-1-rui.silva@xxxxxxxxxx/


History:
v4:
- Add **cc arg to __capture_try_fmt_vid_cap() to validate colorspace,
   instead of calling ipu_pixelformat_to_colorspace().
- Add error message if capture format validation failed.
v3:
- A couple patches did not compile/link. All patches now build so the
   series is fully bisectable. No functional changes.
v2:
- Added a patch that improves the pipeline upstream/downstream search
   functions, which no longer require the media device.
- Add a patch to remove getting media device from v4l2_dev driver data.


Steve Longerbeam (8):
   media: staging/imx: Switch to sync registration for IPU subdevs
   media: staging/imx: Pass device to alloc/free_dma_buf
   media: staging/imx: Move add_video_device into capture_device_register
   Revert "media: imx: Set capture compose rectangle in
     capture_device_set_format"
   media: staging/imx: Remove capture_device_set_format
   media: staging/imx: Re-organize modules
   media: staging/imx: Improve pipeline searching
   media: staging/imx: Don't set driver data for v4l2_dev

  drivers/staging/media/imx/Makefile            |  18 +-
  drivers/staging/media/imx/imx-ic-common.c     |  68 +--
  drivers/staging/media/imx/imx-ic-prp.c        |  36 +-
  drivers/staging/media/imx/imx-ic-prpencvf.c   |  88 ++--
  drivers/staging/media/imx/imx-ic.h            |   6 +-
  drivers/staging/media/imx/imx-media-capture.c |  90 ++--
  drivers/staging/media/imx/imx-media-csi.c     |  45 +-
  .../staging/media/imx/imx-media-dev-common.c  | 346 +++++++++++++-
  drivers/staging/media/imx/imx-media-dev.c     | 449 +-----------------
  drivers/staging/media/imx/imx-media-fim.c     |   9 -
  .../staging/media/imx/imx-media-internal-sd.c | 357 ++++++--------
  drivers/staging/media/imx/imx-media-of.c      |  41 +-
  drivers/staging/media/imx/imx-media-utils.c   | 170 +++----
  drivers/staging/media/imx/imx-media-vdic.c    |  84 +---
  drivers/staging/media/imx/imx-media.h         | 113 +++--
  drivers/staging/media/imx/imx7-media-csi.c    |  43 +-
  16 files changed, 857 insertions(+), 1106 deletions(-)





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux