Re: [PULL] http://linuxtv.org/hg/~jfrancois/v4l-dvb/

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jean-Francois Moine wrote:
> Hi Mauro,
> 
> Please pull from http://linuxtv.org/hg/~jfrancois/v4l-dvb
> 
> for the following 9 changesets:
> 
> 01/09: gspca - zc3xx: Change the resolutions of some sensors.
> http://linuxtv.org/hg/~jfrancois/v4l-dvb?cmd=changeset;node=b2c81ce31b88
> 
> 02/09: gspca - pac7302/pac7311: Remove the unused page loading.
> http://linuxtv.org/hg/~jfrancois/v4l-dvb?cmd=changeset;node=8c4f87786f70
> 
> 03/09: gspca - pac7302: Use usb_err to propagate USB errors.
> http://linuxtv.org/hg/~jfrancois/v4l-dvb?cmd=changeset;node=89e8a8fb18ab

Huh?
-static int reg_w_buf(struct gspca_dev *gspca_dev,
+static void reg_w_buf(struct gspca_dev *gspca_dev,
                  __u8 index,
                  const char *buffer, int len)
 {
        int ret;
 
+       if (gspca_dev->usb_err < 0)
+               return;

This is an ugly and non-standard way to report errors in C. Just return the error
code.


> 
> 04/09: gspca - pac7311: Use usb_err to propagate USB errors.
> http://linuxtv.org/hg/~jfrancois/v4l-dvb?cmd=changeset;node=ec69be3f2189

The same applies here. 

Cheers
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux