Compile tested this series and I get the following sparse/smatch wanings: sparse: WARNINGS SPARSE:/home/hans/work/build/media-git/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c /home/hans/work/build/media-git/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:38:6: warning: symbol 'rockchip_vpu_get_ctrl' was not declared. Should it be static? SPARSE:/home/hans/work/build/media-git/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c /home/hans/work/build/media-git/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:46:12: warning: symbol 'rockchip_vpu_get_ref' was not declared. Should it be static? /home/hans/work/build/media-git/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:38:7: warning: no previous prototype for 'rockchip_vpu_get_ctrl' [-Wmissing-prototypes] /home/hans/work/build/media-git/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:46:12: warning: no previous prototype for 'rockchip_vpu_get_ref' [-Wmissing-prototypes] /home/hans/work/build/media-git/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:298:6: warning: variable 'j' set but not used [-Wunused-but-set-variable] smatch: WARNINGS /home/hans/work/build/media-git/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:38:7: warning: no previous prototype for 'rockchip_vpu_get_ctrl' [-Wmissing-prototypes] /home/hans/work/build/media-git/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:46:12: warning: no previous prototype for 'rockchip_vpu_get_ref' [-Wmissing-prototypes] /home/hans/work/build/media-git/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c:298:6: warning: variable 'j' set but not used [-Wunused-but-set-variable] Looks trivial to fix. Regards, Hans
