Hi André, thanks for the patch.
On 4/24/19 10:56 AM, André Almeida wrote:
> Add a multiplanar flag in vimc_stream in order to propagate the
> state (singleplanar/multiplanar) to subdevices at the stream.
This shouldn't be required as you are using multiplanar only between the
subdevices :)
Helen
>
> Signed-off-by: André Almeida <andrealmeid@xxxxxxxxxxxxx>
> ---
> Change in v3:
> - Use ternary operator to get code more simple
>
> Change in v2:
> - New commit
>
> drivers/media/platform/vimc/vimc-capture.c | 4 +++-
> drivers/media/platform/vimc/vimc-streamer.h | 3 +++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vimc/vimc-capture.c b/drivers/media/platform/vimc/vimc-capture.c
> index 415dbab63ec5..e1805cf0140d 100644
> --- a/drivers/media/platform/vimc/vimc-capture.c
> +++ b/drivers/media/platform/vimc/vimc-capture.c
> @@ -337,7 +337,9 @@ static int vimc_cap_start_streaming(struct vb2_queue *vq, unsigned int count)
> return ret;
> }
>
> - vcap->stream.producer_pixfmt = IS_MULTIPLANAR(vcap) ?
> + vcap->stream.multiplanar = IS_MULTIPLANAR(vcap);
> +
> + vcap->stream.producer_pixfmt = vcap->stream.multiplanar ?
> vcap->format.fmt.pix_mp.pixelformat :
> vcap->format.fmt.pix.pixelformat;
>
> diff --git a/drivers/media/platform/vimc/vimc-streamer.h b/drivers/media/platform/vimc/vimc-streamer.h
> index 2b3667408794..4878e0b72ea7 100644
> --- a/drivers/media/platform/vimc/vimc-streamer.h
> +++ b/drivers/media/platform/vimc/vimc-streamer.h
> @@ -25,6 +25,8 @@
> * processed in the pipeline.
> * @pipe_size: size of @ved_pipeline
> * @kthread: thread that generates the frames of the stream.
> + * @multiplanar: sets if the stream is running in multiplanar or
> + * singleplanar format mode
> * @producer_pixfmt: the pixel format requested from the pipeline. This must
> * be set just before calling vimc_streamer_s_stream(ent, 1). This value is
> * propagated up to the source of the base image (usually a sensor node) and
> @@ -40,6 +42,7 @@ struct vimc_stream {
> struct vimc_ent_device *ved_pipeline[VIMC_STREAMER_PIPELINE_MAX_SIZE];
> unsigned int pipe_size;
> struct task_struct *kthread;
> + bool multiplanar;
> u32 producer_pixfmt;
> };
>
>
