Hi Kefeng, Thanks for the patch. On Tue 23 Apr 2019 at 08:50, Kefeng Wang wrote: > Using dev_get_drvdata directly. > > Cc: Rui Miguel Silva <rmfrfs@xxxxxxxxx> There was already a patch sent by Wolfram that does the same thing [0]. Thanks anyway. --- Cheers, Rui [0]: https://lore.kernel.org/linux-media/20190319163622.30607-1-wsa+renesas@xxxxxxxxxxxxxxxxxxxx/ > Cc: Steve Longerbeam <slongerbeam@xxxxxxxxx> > Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > Cc: NXP Linux Team <linux-imx@xxxxxxx> > Cc: linux-media@xxxxxxxxxxxxxxx > Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx> > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index 6cae2960eea1..19455f425416 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -1027,8 +1027,7 @@ static int mipi_csis_probe(struct platform_device *pdev) > > static int mipi_csis_pm_suspend(struct device *dev, bool runtime) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct v4l2_subdev *mipi_sd = platform_get_drvdata(pdev); > + struct v4l2_subdev *mipi_sd = dev_get_drvdata(dev); > struct csi_state *state = mipi_sd_to_csis_state(mipi_sd); > int ret = 0; > > @@ -1052,8 +1051,7 @@ static int mipi_csis_pm_suspend(struct device *dev, bool runtime) > > static int mipi_csis_pm_resume(struct device *dev, bool runtime) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct v4l2_subdev *mipi_sd = platform_get_drvdata(pdev); > + struct v4l2_subdev *mipi_sd = dev_get_drvdata(dev); > struct csi_state *state = mipi_sd_to_csis_state(mipi_sd); > int ret = 0;