On 2019-04-22 10:08, Boris Brezillon wrote: > From: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx> Please restore my commit authorship, it seems to have changed in v3. I would appreciate if you can pick the fixups from [1] and [2] to sync rk3288/rk3399 code. Please also squash both MPEG-2 commits, that is closer to the original commit at [4]. This module seems to crash after repeated rmmod / insmod, calls to video_device_release seems to be the culprit for crash. There is also an issue with uneven pm runtime autosuspend calls leaving clocks enabled when module is unloaded. Feel free to pick/squash any of the changes at [3], they fixes the crash and uneven autosuspend for me. MPEG-2 decoding is working on my RK3288 and RK3399 devices. Fixup commits: [1] https://github.com/Kwiboo/linux-rockchip/commit/8d8b5aca522176d17b6a0f13da57fd9b8e7d1e9a [2] https://github.com/Kwiboo/linux-rockchip/commit/75de5f322ffe889154832f6ebfb08e48257af526 [3] https://github.com/Kwiboo/linux-rockchip/commit/0729b53c825a630c9040d28541d2635a42177361 Original MPEG-2 commit: [4] https://github.com/Kwiboo/linux-rockchip/commit/25d9502927540c6f17c65d52a350b28c664cbf5a Thanks, Jonas > > Add MPEG-2 decoding, only on RK3399. Other SoCs > and support for other codecs will be added in the future. > > Signed-off-by: Jonas Karlman <jonas@xxxxxxxxx> > Signed-off-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx> > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> > -- > Changes from v2: > * Remove uneeded check from rockchip_vpu_get_ctrl. > * Use user negotiated resolution when programming the hardware. > --- > drivers/staging/media/rockchip/vpu/Makefile | 4 +- > .../media/rockchip/vpu/rk3399_vpu_hw.c | 40 ++- > .../rockchip/vpu/rk3399_vpu_hw_mpeg2_dec.c | 273 ++++++++++++++++++ > .../staging/media/rockchip/vpu/rockchip_vpu.h | 9 + > .../media/rockchip/vpu/rockchip_vpu_common.h | 3 + > .../media/rockchip/vpu/rockchip_vpu_drv.c | 30 ++ > .../media/rockchip/vpu/rockchip_vpu_hw.h | 15 + > .../media/rockchip/vpu/rockchip_vpu_mpeg2.c | 61 ++++ > 8 files changed, 433 insertions(+), 2 deletions(-) > create mode 100644 drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_mpeg2_dec.c > create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_mpeg2.c > > ...
