Hi Kieran,
Thank you for the patch.
On Thu, Apr 11, 2019 at 05:12:52PM +0100, Kieran Bingham wrote:
> Provide a helper to describe when the partition algorithm is in use on a
> given pipeline. This improves readability to the purpose of the code,
s/ / /
> rather than obtusely checking the number of partitions.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/vsp1/vsp1_pipe.c | 8 ++++++++
> drivers/media/platform/vsp1/vsp1_pipe.h | 1 +
> drivers/media/platform/vsp1/vsp1_rpf.c | 2 +-
> drivers/media/platform/vsp1/vsp1_video.c | 2 +-
> drivers/media/platform/vsp1/vsp1_wpf.c | 2 +-
> 5 files changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_pipe.c b/drivers/media/platform/vsp1/vsp1_pipe.c
> index 54ff539ffea0..f1bd21a01bcd 100644
> --- a/drivers/media/platform/vsp1/vsp1_pipe.c
> +++ b/drivers/media/platform/vsp1/vsp1_pipe.c
> @@ -364,6 +364,14 @@ void vsp1_pipeline_propagate_alpha(struct vsp1_pipeline *pipe,
> vsp1_uds_set_alpha(pipe->uds, dlb, alpha);
> }
>
> +/*
> + * Identify if the partition algorithm is in use or not
s/$/./
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> + */
> +bool vsp1_pipeline_partitioned(struct vsp1_pipeline *pipe)
> +{
> + return pipe->partitions > 1;
> +}
> +
> /*
> * Propagate the partition calculations through the pipeline
> *
> diff --git a/drivers/media/platform/vsp1/vsp1_pipe.h b/drivers/media/platform/vsp1/vsp1_pipe.h
> index ae646c9ef337..dd8b2cdc6452 100644
> --- a/drivers/media/platform/vsp1/vsp1_pipe.h
> +++ b/drivers/media/platform/vsp1/vsp1_pipe.h
> @@ -164,6 +164,7 @@ void vsp1_pipeline_propagate_alpha(struct vsp1_pipeline *pipe,
> struct vsp1_dl_body *dlb,
> unsigned int alpha);
>
> +bool vsp1_pipeline_partitioned(struct vsp1_pipeline *pipe);
> void vsp1_pipeline_propagate_partition(struct vsp1_pipeline *pipe,
> struct vsp1_partition *partition,
> unsigned int index,
> diff --git a/drivers/media/platform/vsp1/vsp1_rpf.c b/drivers/media/platform/vsp1/vsp1_rpf.c
> index 616afa7e165f..ef9bf5dd55a0 100644
> --- a/drivers/media/platform/vsp1/vsp1_rpf.c
> +++ b/drivers/media/platform/vsp1/vsp1_rpf.c
> @@ -269,7 +269,7 @@ static void rpf_configure_partition(struct vsp1_entity *entity,
> * matching the expected partition window. Only 'left' and
> * 'width' need to be adjusted.
> */
> - if (pipe->partitions > 1) {
> + if (vsp1_pipeline_partitioned(pipe)) {
> crop.width = pipe->partition->rpf.width;
> crop.left += pipe->partition->rpf.left;
> }
> diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c
> index 7ceaf3222145..ee2fb8261a6a 100644
> --- a/drivers/media/platform/vsp1/vsp1_video.c
> +++ b/drivers/media/platform/vsp1/vsp1_video.c
> @@ -201,7 +201,7 @@ static void vsp1_video_calculate_partition(struct vsp1_pipeline *pipe,
> RWPF_PAD_SINK);
>
> /* A single partition simply processes the output size in full. */
> - if (pipe->partitions <= 1) {
> + if (!vsp1_pipeline_partitioned(pipe)) {
> window.left = 0;
> window.width = format->width;
>
> diff --git a/drivers/media/platform/vsp1/vsp1_wpf.c b/drivers/media/platform/vsp1/vsp1_wpf.c
> index 32bb207b2007..9e8dbf99878b 100644
> --- a/drivers/media/platform/vsp1/vsp1_wpf.c
> +++ b/drivers/media/platform/vsp1/vsp1_wpf.c
> @@ -376,7 +376,7 @@ static void wpf_configure_partition(struct vsp1_entity *entity,
> * Cropping. The partition algorithm can split the image into
> * multiple slices.
> */
> - if (pipe->partitions > 1)
> + if (vsp1_pipeline_partitioned(pipe))
> width = pipe->partition->wpf.width;
>
> vsp1_wpf_write(wpf, dlb, VI6_WPF_HSZCLIP, VI6_WPF_SZCLIP_EN |
> --
> 2.19.1
>
--
Regards,
Laurent Pinchart
