Hi Bingbu, On Fri, Mar 22, 2019 at 8:00 PM <bingbu.cao@xxxxxxxxx> wrote: > > From: Bingbu Cao <bingbu.cao@xxxxxxxxx> > > Current ImgU driver processes and releases the parameter buffer > immediately after queued from user. This does not align with other > image buffers which are grouped in sets and used for the same frame. > If user queues multiple parameter buffers continuously, only the last > one will take effect. > To make consistent buffers usage, this patch changes the parameter > buffer handling and group parameter buffer with other image buffers > for each frame. > Each time driver will queue one more group of buffers when previous > frame processed and buffers consumed by css. > > Signed-off-by: Tianshu Qiu <tian.shu.qiu@xxxxxxxxx> > Signed-off-by: Bingbu Cao <bingbu.cao@xxxxxxxxx> > --- > drivers/staging/media/ipu3/ipu3-css.c | 5 ---- > drivers/staging/media/ipu3/ipu3-v4l2.c | 46 ++++++++++++---------------------- > drivers/staging/media/ipu3/ipu3.c | 30 ++++++++++++++++++++++ > 3 files changed, 46 insertions(+), 35 deletions(-) > > --- > changes since v1: > - add payload check for parameter buffer > - queue buffer only when previous buffer consumed > --- Thanks for the patch. With the issues pointed by Sakari fixed (+/- those for follow up patches): Reviewed-by: Tomasz Figa <tfiga@xxxxxxxxxxxx> By the way, has this been tested on an applicable platform with applicable platform (e.g. Pixel Slate with Chrome OS) and found no performance or functional regressions? Best regards, Tomasz
