On Fri, 12 Apr 2019 12:16:42 +0200 Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> wrote: > Hi, > > On 4/12/19 11:20, Boris Brezillon wrote: > > The fimc-isp-video.c and fimc-lite.c were missing the > > V4L2_CAP_VIDEO_CAPTURE_MPLANE flag when reporting device caps. > > Th omission was intentional, as these video nodes cannot be used > by "standard" V4L2 capture applications. Some sub-devices need to > be configured first in order to use these video nodes. It was > agreed to not set these capabilities in the driver, instead user > space library, e.g. libv4l2 with driver-specific plugin handling > the media controller and v4l2 subdev calls would set the capability > for the applications. Has something changed? > Hm, maybe I should just drop the extra consistency check I added in v4l_enum_fmt() and call ->vidioc_enum_fmt_vid_{cap,out}() unconditionally.