Hi, Stu: On Mon, 2019-04-08 at 19:54 +0800, Stu Hsieh wrote: > This patch add mediatek mipicsi driver for mt2712, > including probe function to get the value from device tree, > and register to v4l2 the host device. > > Signed-off-by: Stu Hsieh <stu.hsieh@xxxxxxxxxxxx> > --- > drivers/media/platform/mtk-mipicsi/Makefile | 4 + > .../media/platform/mtk-mipicsi/mtk_mipicsi.c | 768 ++++++++++++++++++ > 2 files changed, 772 insertions(+) > create mode 100644 drivers/media/platform/mtk-mipicsi/Makefile > create mode 100644 drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c > [snip] > + > +static const struct of_device_id mtk_mipicsi_of_match[] = { > + { .compatible = "mediatek,mt2712-mipicsi", }, Where is the binding document of "mediatek,mt2712-mipicsi"? Regards, CK > + {}, > +}; > + > +static struct platform_driver mtk_mipicsi_driver = { > + .driver = { > + .name = MTK_MIPICSI_DRV_NAME, > + .of_match_table = of_match_ptr(mtk_mipicsi_of_match), > + }, > + .probe = mtk_mipicsi_probe, > + .remove = mtk_mipicsi_remove, > +}; > + > +module_platform_driver(mtk_mipicsi_driver); > +MODULE_DESCRIPTION("MediaTek SoC Camera Host driver"); > +MODULE_LICENSE("GPL v2");