On Thu, Apr 04, 2019 at 03:39:41PM +0200, Hans Verkuil wrote:
> On 3/18/19 8:16 PM, Sakari Ailus wrote:
> > v4l2_async_notifier_add_fwnode_remote_subdev is a convenience function for
> > parsing information on V4L2 fwnode subdevs.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > ---
> > drivers/media/v4l2-core/v4l2-async.c | 23 +++++++++++++++++++++++
> > include/media/v4l2-async.h | 24 ++++++++++++++++++++++++
> > 2 files changed, 47 insertions(+)
> >
> > diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
> > index 4cb49d5f8c03..9c1937d6ce17 100644
> > --- a/drivers/media/v4l2-core/v4l2-async.c
> > +++ b/drivers/media/v4l2-core/v4l2-async.c
> > @@ -608,6 +608,29 @@ v4l2_async_notifier_add_fwnode_subdev(struct v4l2_async_notifier *notifier,
> > }
> > EXPORT_SYMBOL_GPL(v4l2_async_notifier_add_fwnode_subdev);
> >
> > +int
> > +v4l2_async_notifier_add_fwnode_remote_subdev(struct v4l2_async_notifier *notif,
> > + struct fwnode_handle *endpoint,
> > + struct v4l2_async_subdev *asd)
> > +{
> > + struct fwnode_handle *remote_ep;
> > + int ret;
> > +
> > + remote_ep = fwnode_graph_get_remote_endpoint(endpoint);
> > + if (!remote_ep)
> > + return -ENOTCONN;
> > +
> > + asd->match_type = V4L2_ASYNC_MATCH_FWNODE;
> > + asd->match.fwnode = remote_ep;
> > +
> > + ret = v4l2_async_notifier_add_subdev(notif, asd);
> > + if (ret)
> > + fwnode_handle_put(remote_ep);
> > +
> > + return ret;
> > +}
> > +EXPORT_SYMBOL_GPL(v4l2_async_notifier_add_fwnode_remote_subdev);
> > +
> > struct v4l2_async_subdev *
> > v4l2_async_notifier_add_i2c_subdev(struct v4l2_async_notifier *notifier,
> > int adapter_id, unsigned short address,
> > diff --git a/include/media/v4l2-async.h b/include/media/v4l2-async.h
> > index 1497bda66c3b..215e73eddfc3 100644
> > --- a/include/media/v4l2-async.h
> > +++ b/include/media/v4l2-async.h
> > @@ -184,6 +184,30 @@ v4l2_async_notifier_add_fwnode_subdev(struct v4l2_async_notifier *notifier,
> > unsigned int asd_struct_size);
> >
> > /**
> > + * v4l2_async_notifier_add_fwnode_remote_subdev - Allocate and add a fwnode
> > + * remote async subdev to the
> > + * notifier's master asd_list.
> > + *
> > + * @notifier: pointer to &struct v4l2_async_notifier
> > + * @endpoint: local endpoint the remote sub-device to be matched
> > + * @asd_struct_size: size of the driver's async sub-device struct, including
> > + * sizeof(struct v4l2_async_subdev). The &struct
> > + * v4l2_async_subdev shall be the first member of
> > + * the driver's async sub-device struct, i.e. both
> > + * begin at the same memory address.
>
> Huh? This argument is @asd, not a struct size. Also it's @notif, not
> @notifier. It seems that this documentation isn't in sync with the actual
> function.
Yes, I'll address this in the next version.
--
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx
