On 4/2/19 1:24 AM, Hans Verkuil wrote:
If the application was streaming from both videoX and vbiX, and streaming from videoX was stopped, then the vbi streaming also stopped. The cause being that stop_streaming for video stopped the subdevs as well, instead of only doing that if dev->streaming_users reached 0. au0828_stop_vbi_streaming was also wrong since it didn't stop the subdevs at all when dev->streaming_users reached 0. Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> --- Change since v1: v4l2_device_call_all(&dev->v4l2_dev, 0, video, s_stream, 1) was done for video only, not for vbi. This is obviously wrong when starting vbi first, but also caused weird behavior since attempting to start a second vbi capture would stop the first. ---
Looks good. Attempting to start the second VBI stream capture doesn't stop the active VBI stream. Tested-by: Shuah Khan <shuah@xxxxxxxxxx> thanks, -- Shuah
