Hi Salvador, Thank you for the patch. On Mon, Apr 01, 2019 at 05:47:26PM +0200, Salvador Fernández wrote: > Hi developers, > > A very simple patch to add support for newer HP Full-HD Camera. > Pgp key for signature is > http://keys.gnupg.net/pks/lookup?op=get&search=0x93360317E5CECDDA Please see Documentation/process/submitting-patches.rst in the kernel sources for an explanation on how to submit patches. Your patch needs to include a Signed-off-by line. I advice using git-send-email to send it out if you can, as that solves lots of issues with e-mail clients. Please see below for a few comments. > Thanks a lot for your work, You're welcome. > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > index 10cfe8e51626..ee9c72543c11 100644 > --- a/drivers/media/usb/uvc/uvc_driver.c > +++ b/drivers/media/usb/uvc/uvc_driver.c > @@ -2510,6 +2510,15 @@ static const struct usb_device_id uvc_ids[] = { > .bInterfaceSubClass = 1, > .bInterfaceProtocol = 0, > .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_RESTRICT_FRAME_RATE) }, > + /* Chicony HP Full-HD Camera (04f2:b62f) */ > + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > + | USB_DEVICE_ID_MATCH_INT_INFO, > + .idVendor = 0x04f2, > + .idProduct = 0xb62f, > + .bInterfaceClass = USB_CLASS_VIDEO, > + .bInterfaceSubClass = 1, > + .bInterfaceProtocol = 0, > + .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_RESTRICT_FRAME_RATE) }, Is this quirk needed ? What happens if you don't specify it ? What happens if the whole device entry isn't added, does the uvcvideo driver print error messages to the kernel log ? > /* Alcor Micro AU3820 (Future Boy PC USB Webcam) */ > { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > | USB_DEVICE_ID_MATCH_INT_INFO, -- Regards, Laurent Pinchart
