Hi Sakari, On Friday, March 29, 2019 7:39:24 PM CET Sakari Ailus wrote: > Hi Janus, > > Thanks for the patchset. > > On Mon, Mar 25, 2019 at 01:35:00AM +0100, Janusz Krzysztofik wrote: > > ... > > > > done: > > ov6650_s_power(&priv->subdev, 0); > > + if (ret) { > > +eclkput: > > + v4l2_clk_put(priv->clk); > > Could you rework the error handling, please? Labels should be outside > conditionals. OK. > See e.g. the smiapp driver > (drivers/media/i2c/smiapp/smiapp-core.c). I've pushed my master branch > here: > > <URL:https://git.linuxtv.org/sailus/media_tree.git/log/> I'm currently syncing my linux-media remote tracking branches with git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media.git Should I switch to a different repository, e.g. yours? Thanks, Janusz