Hi Eugen, On 3/28/19 4:32 PM, Eugen.Hristev@xxxxxxxxxxxxx wrote: > From: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx> > > This change is a redesign in the formats and the way the ISC is > configured w.r.t. sensor format and the output format from the ISC. > I have changed the splitting between sensor output (which is also ISC input) > and ISC output. > The sensor format represents the way the sensor is configured, and what ISC > is receiving. > The format configuration represents the way ISC is interpreting the data and > formatting the output to the subsystem. > Now it's much easier to figure out what is the ISC configuration for input, and > what is the configuration for output. > The non-raw format can be obtained directly from sensor or it can be done > inside the ISC. The controller format list will include a configuration for > each format. > The old supported formats are still in place, if we want to dump the sensor > format directly to the output, the try format routine will detect and > configure the pipeline accordingly. > This also fixes the previous issues when the raw format was NULL which > resulted in many crashes for sensors which did not have the expected/tested > formats. > > Signed-off-by: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx> I'm getting a few smatch warnings/errors: drivers/media/platform/atmel/atmel-isc.c:1368 isc_try_fmt() error: we previously assumed 'sd_fmt' could be null (see line 1343) drivers/media/platform/atmel/atmel-isc.c:1078:35: warning: variable 'rgb' set but not used [-Wunused-but-set-variable] drivers/media/platform/atmel/atmel-isc.c:1078:22: warning: variable 'yuv' set but not used [-Wunused-but-set-variable] Can you take a look? Thanks! Hans
