> On Mar 9, 2019, at 1:42 AM, Kangjie Lu <kjlu@xxxxxxx> wrote: > > In case usb_alloc_coherent fails, the fix returns -ENOMEM to > avoid a potential NULL pointer dereference. > > Signed-off-by: Kangjie Lu <kjlu@xxxxxxx> > --- > drivers/media/usb/usbvision/usbvision-core.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/usb/usbvision/usbvision-core.c b/drivers/media/usb/usbvision/usbvision-core.c > index 31e0e98d6daf..1b0d0a0f0e87 100644 > --- a/drivers/media/usb/usbvision/usbvision-core.c > +++ b/drivers/media/usb/usbvision/usbvision-core.c > @@ -2302,6 +2302,9 @@ int usbvision_init_isoc(struct usb_usbvision *usbvision) > sb_size, > GFP_KERNEL, > &urb->transfer_dma); > + if (!usbvision->sbuf[buf_idx].data) > + return -ENOMEM; > + Can someone review this patch? > urb->dev = dev; > urb->context = usbvision; > urb->pipe = usb_rcvisocpipe(dev, usbvision->video_endp); > -- > 2.17.1 >
