Em Wed, 20 Mar 2019 11:39:47 +0100
Hans Verkuil <hverkuil@xxxxxxxxx> escreveu:
> On 3/20/19 11:11 AM, Mauro Carvalho Chehab wrote:
> > Em Wed, 6 Mar 2019 13:13:22 -0800
> > Dafna Hirschfeld <dafna3@xxxxxxxxx> escreveu:
> >
> >> From: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
> >>
> >> Add capability to indicate that requests are required instead of
> >> merely supported.
> >
> > Not sure if I liked this patch, and for sure it lacks a lot of documentation:
> >
> > First of all, the patch description doesn't help. For example, it doesn't
> > explain or mention any use case example that would require (instead of
> > merely support) a request.
>
> Stateless codecs require the use of requests (i.e. they can't function without
> this).
>
> However, right now every driver has to check for this and return an error when
> an attempt is made to stream without requests.
>
> And userspace has no way of knowing whether requests are required by the driver
> as opposed to being optional.
>
> That's what this attempts to do: show to userspace that requests are required,
> and add a vb2 flag that will force the core to check this so drivers do not need
> to test for it.
>
> Currently the only drivers that would need this are cedrus and vicodec.
I see. Please add a comment like that at this patch's description.
>
> >
> >>
> >> Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
> >> ---
> >> Documentation/media/uapi/v4l/vidioc-reqbufs.rst | 4 ++++
> >> include/uapi/linux/videodev2.h | 1 +
> >> 2 files changed, 5 insertions(+)
> >>
> >> diff --git a/Documentation/media/uapi/v4l/vidioc-reqbufs.rst b/Documentation/media/uapi/v4l/vidioc-reqbufs.rst
> >> index d7faef10e39b..d42a3d9a7db3 100644
> >> --- a/Documentation/media/uapi/v4l/vidioc-reqbufs.rst
> >> +++ b/Documentation/media/uapi/v4l/vidioc-reqbufs.rst
> >> @@ -125,6 +125,7 @@ aborting or finishing any DMA in progress, an implicit
> >> .. _V4L2-BUF-CAP-SUPPORTS-DMABUF:
> >> .. _V4L2-BUF-CAP-SUPPORTS-REQUESTS:
> >> .. _V4L2-BUF-CAP-SUPPORTS-ORPHANED-BUFS:
> >> +.. _V4L2-BUF-CAP-REQUIRES-REQUESTS:
> >>
> >> .. cssclass:: longtable
> >>
> >> @@ -150,6 +151,9 @@ aborting or finishing any DMA in progress, an implicit
> >> - The kernel allows calling :ref:`VIDIOC_REQBUFS` while buffers are still
> >> mapped or exported via DMABUF. These orphaned buffers will be freed
> >> when they are unmapped or when the exported DMABUF fds are closed.
> >> + * - ``V4L2_BUF_CAP_REQUIRES_REQUESTS``
> >> + - 0x00000020
> >> + - This buffer type requires the use of :ref:`requests <media-request-api>`.
> >
> > And the documentation here is really poor, as it doesn't explain what's
> > the API and drivers expected behavior with regards to this flag.
> >
> > I mean, if, on a new driver, requests are mandatory, what happens if a
> > non-request-API aware application tries to use it?
>
> An error will be returned. And that error needs to be documented, I agree.
As discussed at the #v4l channel, EBADR error code seems to be an
appropriate error code for it. Please document it.
>
> All this does is shift the check from the driver to the v4l2 core. It doesn't
> change anything for userspace, except that with this capability flag userspace
> can detect beforehand that requests are required.
Yeah, checking at the core makes sense.
>
> >
> > Another thing that concerns me a lot is that people might want to add it
> > to existing drivers. Well, if an application was written before the
> > addition of this driver, and request API become mandatory, such app
> > will stop working, if it doesn't use request API.
> > At very least, it should be mentioned somewhere that existing drivers
> > should never set this flag, as this would break it for existing
> > userspace apps.
> >
> > Still, I would prefer to not have to add something like that.
>
> The only affected driver is the staging cedrus driver. And that will
> actually crash if you try to use it without requests.
>
> If you look at patch 3 you'll see that it just sets the flag and doesn't
> remove any code that was supposed to check for use-without-requests.
> That's because there never was a check and the driver would just crash.
>
> So we're safe here.
Making it mandatory for the cedrus driver makes sense, but no other
current driver should ever use it.
The problem I see is that, as we advance on improving the requests API,
non-stateless-codec drivers may end supporting the request API.
That's perfectly fine, but such other drivers should *never* be
changed to use V4L2_BUF_CAP_REQUIRES_REQUESTS. This also applies to any
new driver that it is not implementing a stateless codec.
Btw, as this seems to be a requirement only for stateless codec drivers,
perhaps we should (at least in Kernelspace) to use, instead, a
V4L2_BUF_CAP_STATELESS_CODEC_ONLY flag, with the V4L2 core would
translate it to V4L2_BUF_CAP_REQUIRES_REQUESTS before returning it to
userspace, and have a special #ifdef at the userspace header, in order
to prevent this flag to be set directly by a random driver.
>
> I believe patches 1-3 make sense, but I also agree that the documentation
> and commit logs can be improved.
>
> I can either respin with updated patches 1-3, or, if you still have concerns,
> drop 1-3 and repost the remainder of the series. But then I'll need to add
> checks against the use of the stateless vicodec decoder without requests in
> patch 21/23.
Whatever you prefer. If the remaining patches don't require it, you could
just tag the pull request as new and ping me on IRC. I'll review the remaining
ones, skipping the V4L2_BUF_CAP_REQUIRES_REQUESTS specific patches.
>
> But this really doesn't belong in a driver. These checks should be done in the
> vb2 core.
Yeah, I agree.
>
> Regards,
>
> Hans
>
> >
> >
> >>
> >> Return Value
> >> ============
> >> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> >> index 1db220da3bcc..97e6a6a968ba 100644
> >> --- a/include/uapi/linux/videodev2.h
> >> +++ b/include/uapi/linux/videodev2.h
> >> @@ -895,6 +895,7 @@ struct v4l2_requestbuffers {
> >> #define V4L2_BUF_CAP_SUPPORTS_DMABUF (1 << 2)
> >> #define V4L2_BUF_CAP_SUPPORTS_REQUESTS (1 << 3)
> >> #define V4L2_BUF_CAP_SUPPORTS_ORPHANED_BUFS (1 << 4)
> >> +#define V4L2_BUF_CAP_REQUIRES_REQUESTS (1 << 5)
> >>
> >> /**
> >> * struct v4l2_plane - plane info for multi-planar buffers
> >
> >
> >
> > Thanks,
> > Mauro
> >
>
Thanks,
Mauro
