On 13.03.2019 23:05, Sakari Ailus wrote: > On Tue, Mar 12, 2019 at 06:16:08PM +0100, Lubomir Rintel wrote: >> On Tue, 2019-03-12 at 00:36 +0900, Akinobu Mita wrote: >>> This patchset fixes the problems introduced by recent change to ov7670. >>> >>> Akinobu Mita (2): >>> media: ov7670: restore default settings after power-up >>> media: ov7670: don't access registers when the device is powered off >>> >>> drivers/media/i2c/ov7670.c | 32 +++++++++++++++++++++++++++----- >>> 1 file changed, 27 insertions(+), 5 deletions(-) >>> >>> Cc: Lubomir Rintel <lkundrak@xxxxx> >>> Cc: Jonathan Corbet <corbet@xxxxxxx> >>> Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> >>> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> >> >> For the both patches in the set: >> >> Reviewed-by: Lubomir Rintel <lkundrak@xxxxx> >> Tested-by: Lubomir Rintel <lkundrak@xxxxx> > > Thanks, guys! > Hi Akinobu, I am having issues with this sensor, and your patches do not fix them for me ( maybe they are not supposed to ) My issues are like this: once I set a format and start streaming, if I stop streaming and reconfigure the format , for example YUYV after RAW, or RGB565 after RAW and viceversa, the sensor looks to have completely messed up settings: images obtained are very bad. This did not happen for me with older kernel version (4.14 stable for example). I can help with testing patches if you need. My setup is with atmel-isc with parallel interface on board at91 sama5d2_xplained Hope this helps, Eugen
