Hello,
On Sat, Mar 16, 2019 at 07:20:28PM +0300, Sergei Shtylyov wrote:
> On 03/16/2019 06:47 PM, Jacopo Mondi wrote:
>
> > Add PHY-specific parameters to MIPI CSI-2 frame descriptor.
> >
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> > ---
> > include/media/v4l2-subdev.h | 42 +++++++++++++++++++++++++++++++------
> > 1 file changed, 36 insertions(+), 6 deletions(-)
> >
> > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> > index 6311f670de3c..eca9633c83bf 100644
> > --- a/include/media/v4l2-subdev.h
> > +++ b/include/media/v4l2-subdev.h
> [...]
> > @@ -371,18 +393,26 @@ enum v4l2_mbus_frame_desc_type {
> > V4L2_MBUS_FRAME_DESC_TYPE_PLATFORM,
> > V4L2_MBUS_FRAME_DESC_TYPE_PARALLEL,
> > V4L2_MBUS_FRAME_DESC_TYPE_CCP2,
> > - V4L2_MBUS_FRAME_DESC_TYPE_CSI2,
> > + V4L2_MBUS_FRAME_DESC_TYPE_CSI2_DPHY,
> > + V4L2_MBUS_FRAME_DESC_TYPE_CSI2_CPHY,
> > };
> >
> > /**
> > * struct v4l2_mbus_frame_desc - media bus data frame description
> > - * @type: type of the bus (enum v4l2_mbus_frame_desc_type)
> > - * @entry: frame descriptors array
> > - * @num_entries: number of entries in @entry array
> > + * @type: type of the bus (enum v4l2_mbus_frame_desc_type)
> > + * @entry: frame descriptors array
> > + * @phy: PHY specific parameters
> > + * @phy.dphy: MIPI D-PHY specific bus configurations
> > + * @phy.cphy: MIPI C-PHY specific bus configurations
>
> The union members have csi2_ prefix in their names, no?
>
Correct! Thanks Sergei for noticing this!
> > + * @num_entries: number of entries in @entry array
> > */
> > struct v4l2_mbus_frame_desc {
> > enum v4l2_mbus_frame_desc_type type;
> > struct v4l2_mbus_frame_desc_entry entry[V4L2_FRAME_DESC_ENTRY_MAX];
> > + union {
> > + struct v4l2_mbus_frame_desc_entry_csi2_dphy csi2_dphy;
> > + struct v4l2_mbus_frame_desc_entry_csi2_cphy csi2_cphy;
> > + } phy;
> > unsigned short num_entries;
> > };
> >
>
Attachment:
signature.asc
Description: PGP signature
