Hi,
On Wed, 2019-03-06 at 13:13 -0800, Dafna Hirschfeld wrote:
> From: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
>
> Add capability to indicate that requests are required instead of
> merely supported.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
Reviewed-by: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx>
Cheers,
Paul
> ---
> Documentation/media/uapi/v4l/vidioc-reqbufs.rst | 4 ++++
> include/uapi/linux/videodev2.h | 1 +
> 2 files changed, 5 insertions(+)
>
> diff --git a/Documentation/media/uapi/v4l/vidioc-reqbufs.rst b/Documentation/media/uapi/v4l/vidioc-reqbufs.rst
> index d7faef10e39b..d42a3d9a7db3 100644
> --- a/Documentation/media/uapi/v4l/vidioc-reqbufs.rst
> +++ b/Documentation/media/uapi/v4l/vidioc-reqbufs.rst
> @@ -125,6 +125,7 @@ aborting or finishing any DMA in progress, an implicit
> .. _V4L2-BUF-CAP-SUPPORTS-DMABUF:
> .. _V4L2-BUF-CAP-SUPPORTS-REQUESTS:
> .. _V4L2-BUF-CAP-SUPPORTS-ORPHANED-BUFS:
> +.. _V4L2-BUF-CAP-REQUIRES-REQUESTS:
>
> .. cssclass:: longtable
>
> @@ -150,6 +151,9 @@ aborting or finishing any DMA in progress, an implicit
> - The kernel allows calling :ref:`VIDIOC_REQBUFS` while buffers are still
> mapped or exported via DMABUF. These orphaned buffers will be freed
> when they are unmapped or when the exported DMABUF fds are closed.
> + * - ``V4L2_BUF_CAP_REQUIRES_REQUESTS``
> + - 0x00000020
> + - This buffer type requires the use of :ref:`requests <media-request-api>`.
>
> Return Value
> ============
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 1db220da3bcc..97e6a6a968ba 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -895,6 +895,7 @@ struct v4l2_requestbuffers {
> #define V4L2_BUF_CAP_SUPPORTS_DMABUF (1 << 2)
> #define V4L2_BUF_CAP_SUPPORTS_REQUESTS (1 << 3)
> #define V4L2_BUF_CAP_SUPPORTS_ORPHANED_BUFS (1 << 4)
> +#define V4L2_BUF_CAP_REQUIRES_REQUESTS (1 << 5)
>
> /**
> * struct v4l2_plane - plane info for multi-planar buffers
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
