Re: [PATCH 1/5] staging: imgu: Switch to __aligned() from __attribute__((aligned()))

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 07, 2019 at 12:00:59PM +0900, Tomasz Figa wrote:
> On Thu, Mar 7, 2019 at 12:00 PM Tomasz Figa <tfiga@xxxxxxxxxxxx> wrote:
> >
> > Hi Sakari,
> >
> > On Wed, Feb 20, 2019 at 8:21 PM Sakari Ailus
> > <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
> > >
> > > __aligned() is preferred. The patch has been generated using the following
> > > command in the drivers/staging/media/ipu3 directory:
> > >
> > > $ git grep -l 'aligned(32)' | \
> > >         xargs perl -i -pe \
> > >         's/__attribute__\s*\(\(\s*aligned\s*\(([0-9]+)\s*\)\s*\)\)/__aligned($1)/g;'
> >
> > Thanks for the patch. These structs are expected to move to uapi/ once
> > the driver leaves staging. Is __aligned() now accessible to uapi
> > headers?
> 
> Ah, just noticed the v2 of the series doesn't include this patch.
> Sorry for the noise.

No worries. I just intended to postpone it first but it seems it's better
to drop it. Handling __aligned(whatever) is a pain with sed --- as it may
be more than just numbers.

-- 
Regards,

Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux