Hi Shaodo, On Thu, Feb 21, 2019 at 05:47:52PM -0700, Shaobo He wrote: > Hello everyone, > > I found that macro `CALLPTR` in drivers/media/v4l2-core/videobuf-core.c can > evaluate to NULL yet all its usages (__videobuf_copy_to_user, > __videobuf_copy_stream) are never NULL checked. I doubt but am not completely > sure that use cases of the CALLPTR macro can accept NULL pointers. Please let me > know if it makes sense or not. videobuf (not to be confused with videobuf2) is old deprecated code, and full of known issues that we will not attempt to solve. It should be dropped, but we still have 8 drivers relying on it. Hans, do you think we will ever move forward with this ? Could some of the drivers be dropped ? -- Regards, Laurent Pinchart
