On Mon, Feb 18, 2019 at 12:21:09PM +0100, Jacopo Mondi wrote: > Hi Laurent, Sakari, > > On Wed, Jan 16, 2019 at 01:53:03AM +0200, Laurent Pinchart wrote: > > Hi Niklas, > > > > Thank you for the patch. > > > > On Fri, Nov 02, 2018 at 12:31:31AM +0100, Niklas Söderlund wrote: > > > From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > > > > > Implement compat IOCTL handling for VIDIOC_SUBDEV_G_ROUTING and > > > VIDIOC_SUBDEV_S_ROUTING IOCTLs. > > > > Let's instead design the ioctl in a way that doesn't require compat > > handling. > > > > Care to explain what makes this ioctl require a compat version? I > don't see assumptions on the word length on the implementation. What > am I missing? The size of the "routes" pointer isn't constant, therefore affecting the memory layout of the struct (and thus requiring compat code). It should be __u64. (Please see my other reply to the same patch.) -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
