Re: IPU3 smatch/sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

On Sat, Feb 16, 2019 at 11:05:18AM +0100, Hans Verkuil wrote:
> Hi Sakari,
> 
> Can you take a look at the IPU3 smatch/sparse warnings?
> 
> See here: https://hverkuil.home.xs4all.nl/logs/Saturday.log
> 
> The two that concern me most are these:
> 
> /home/hans/work/build/media-git/drivers/staging/media/ipu3/include/intel-ipu3.h:2475:35: warning: 'awb_fr' offset 36756 in 'struct
> ipu3_uapi_acc_param' isn't aligned to 32 [-Wpacked-not-aligned]
> 
> /home/hans/work/build/media-git/drivers/staging/media/ipu3/ipu3-abi.h:1250:1: warning: alignment 1 of 'struct imgu_abi_awb_fr_config' is
> less than 32 [-Wpacked-not-aligned]
> 
> You can ignore these two sparse warnings:
> 
> /home/hans/work/build/media-git/drivers/staging/media/ipu3/ipu3-css-params.c:1743:15: warning: memset with byte count of 285120
> /home/hans/work/build/media-git/drivers/staging/media/ipu3/ipu3-css-params.c:2284:15: warning: memset with byte count of 240832
> 
> They are bogus and they should disappear since I now added the
> -fmemcpy-max-count=300000 option to sparse.
> 
> The other ipu3 warnings all seem trivial to fix.
> 
> I'm trying to get the build to run without sparse/smatch warnings, so
> getting this fixed will be very useful.

I'll try to get this done early next week.

-- 
Regards,

Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux