Hi Dafna, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20190215] [cannot apply to v5.0-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Dafna-Hirschfeld/add-support-to-stateless-decoder/20190216-051151 base: git://linuxtv.org/media_tree.git master config: x86_64-randconfig-x019-201906 (attached as .config) compiler: gcc-8 (Debian 8.2.0-20) 8.2.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/media/platform/vicodec/vicodec-core.c: In function 'queue_init': >> drivers/media/platform/vicodec/vicodec-core.c:1476:10: error: 'struct vb2_queue' has no member named 'requires_requests'; did you mean 'uses_requests'? src_vq->requires_requests = ctx->is_stateless ? true : false; ^~~~~~~~~~~~~~~~~ uses_requests vim +1476 drivers/media/platform/vicodec/vicodec-core.c 1453 1454 static int queue_init(void *priv, struct vb2_queue *src_vq, 1455 struct vb2_queue *dst_vq) 1456 { 1457 struct vicodec_ctx *ctx = priv; 1458 int ret; 1459 1460 src_vq->type = (multiplanar ? 1461 V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE : 1462 V4L2_BUF_TYPE_VIDEO_OUTPUT); 1463 src_vq->io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF; 1464 src_vq->drv_priv = ctx; 1465 src_vq->buf_struct_size = sizeof(struct v4l2_m2m_buffer); 1466 src_vq->ops = &vicodec_qops; 1467 src_vq->mem_ops = &vb2_vmalloc_memops; 1468 src_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY; 1469 if (ctx->is_enc) 1470 src_vq->lock = &ctx->dev->stateful_enc.mutex; 1471 else if (ctx->is_stateless) 1472 src_vq->lock = &ctx->dev->stateless_dec.mutex; 1473 else 1474 src_vq->lock = &ctx->dev->stateful_dec.mutex; 1475 src_vq->supports_requests = ctx->is_stateless ? true : false; > 1476 src_vq->requires_requests = ctx->is_stateless ? true : false; 1477 ret = vb2_queue_init(src_vq); 1478 if (ret) 1479 return ret; 1480 1481 dst_vq->type = (multiplanar ? 1482 V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE : 1483 V4L2_BUF_TYPE_VIDEO_CAPTURE); 1484 dst_vq->io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF; 1485 dst_vq->drv_priv = ctx; 1486 dst_vq->buf_struct_size = sizeof(struct v4l2_m2m_buffer); 1487 dst_vq->ops = &vicodec_qops; 1488 dst_vq->mem_ops = &vb2_vmalloc_memops; 1489 dst_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY; 1490 dst_vq->lock = src_vq->lock; 1491 1492 return vb2_queue_init(dst_vq); 1493 } 1494 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
