Hi Akinobu, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20190208] [cannot apply to v5.0-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Akinobu-Mita/media-i2c-tweak-Kconfig-dependencies/20190208-233718 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-x0-02100114 (attached as .config) compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010 reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): drivers/media/i2c/mt9m111.c: In function 'mt9m111_get_fmt': >> drivers/media/i2c/mt9m111.c:530:8: error: implicit declaration of function 'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration] mf = v4l2_subdev_get_try_format(sd, cfg, format->pad); ^ >> drivers/media/i2c/mt9m111.c:530:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion] mf = v4l2_subdev_get_try_format(sd, cfg, format->pad); ^ drivers/media/i2c/mt9m111.c: In function 'mt9m111_init_cfg': >> drivers/media/i2c/mt9m111.c:1107:3: warning: initialization makes pointer from integer without a cast [-Wint-conversion] v4l2_subdev_get_try_format(sd, cfg, 0); ^ drivers/media/i2c/mt9m111.c: In function 'mt9m111_probe': drivers/media/i2c/mt9m111.c:1290:17: error: 'struct v4l2_subdev' has no member named 'entity' mt9m111->subdev.entity.function = MEDIA_ENT_F_CAM_SENSOR; ^ drivers/media/i2c/mt9m111.c:1291:47: error: 'struct v4l2_subdev' has no member named 'entity' ret = media_entity_pads_init(&mt9m111->subdev.entity, 1, &mt9m111->pad); ^ cc1: some warnings being treated as errors vim +/v4l2_subdev_get_try_format +530 drivers/media/i2c/mt9m111.c 6a6c8786 drivers/media/video/mt9m111.c Guennadi Liakhovetski 2009-08-25 518 da298c6d drivers/media/i2c/soc_camera/mt9m111.c Hans Verkuil 2015-04-09 519 static int mt9m111_get_fmt(struct v4l2_subdev *sd, da298c6d drivers/media/i2c/soc_camera/mt9m111.c Hans Verkuil 2015-04-09 520 struct v4l2_subdev_pad_config *cfg, da298c6d drivers/media/i2c/soc_camera/mt9m111.c Hans Verkuil 2015-04-09 521 struct v4l2_subdev_format *format) 6a6c8786 drivers/media/video/mt9m111.c Guennadi Liakhovetski 2009-08-25 522 { da298c6d drivers/media/i2c/soc_camera/mt9m111.c Hans Verkuil 2015-04-09 523 struct v4l2_mbus_framefmt *mf = &format->format; 2768cbbb drivers/media/video/mt9m111.c Guennadi Liakhovetski 2011-06-07 524 struct mt9m111 *mt9m111 = container_of(sd, struct mt9m111, subdev); 6a6c8786 drivers/media/video/mt9m111.c Guennadi Liakhovetski 2009-08-25 525 da298c6d drivers/media/i2c/soc_camera/mt9m111.c Hans Verkuil 2015-04-09 526 if (format->pad) da298c6d drivers/media/i2c/soc_camera/mt9m111.c Hans Verkuil 2015-04-09 527 return -EINVAL; da298c6d drivers/media/i2c/soc_camera/mt9m111.c Hans Verkuil 2015-04-09 528 49410d3a drivers/media/i2c/mt9m111.c Akinobu Mita 2019-01-15 529 if (format->which == V4L2_SUBDEV_FORMAT_TRY) { 49410d3a drivers/media/i2c/mt9m111.c Akinobu Mita 2019-01-15 @530 mf = v4l2_subdev_get_try_format(sd, cfg, format->pad); 49410d3a drivers/media/i2c/mt9m111.c Akinobu Mita 2019-01-15 531 format->format = *mf; 49410d3a drivers/media/i2c/mt9m111.c Akinobu Mita 2019-01-15 532 return 0; 49410d3a drivers/media/i2c/mt9m111.c Akinobu Mita 2019-01-15 533 } 49410d3a drivers/media/i2c/mt9m111.c Akinobu Mita 2019-01-15 534 da673e60 drivers/media/video/mt9m111.c Guennadi Liakhovetski 2011-11-04 535 mf->width = mt9m111->width; da673e60 drivers/media/video/mt9m111.c Guennadi Liakhovetski 2011-11-04 536 mf->height = mt9m111->height; 760697be drivers/media/video/mt9m111.c Guennadi Liakhovetski 2009-12-11 537 mf->code = mt9m111->fmt->code; 01f5a394 drivers/media/video/mt9m111.c Michael Grzeschik 2010-08-03 538 mf->colorspace = mt9m111->fmt->colorspace; 760697be drivers/media/video/mt9m111.c Guennadi Liakhovetski 2009-12-11 539 mf->field = V4L2_FIELD_NONE; 2e1566ab drivers/media/i2c/mt9m111.c Akinobu Mita 2019-01-15 540 mf->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT; 2e1566ab drivers/media/i2c/mt9m111.c Akinobu Mita 2019-01-15 541 mf->quantization = V4L2_QUANTIZATION_DEFAULT; 2e1566ab drivers/media/i2c/mt9m111.c Akinobu Mita 2019-01-15 542 mf->xfer_func = V4L2_XFER_FUNC_DEFAULT; 6a6c8786 drivers/media/video/mt9m111.c Guennadi Liakhovetski 2009-08-25 543 6a6c8786 drivers/media/video/mt9m111.c Guennadi Liakhovetski 2009-08-25 544 return 0; 6a6c8786 drivers/media/video/mt9m111.c Guennadi Liakhovetski 2009-08-25 545 } 6a6c8786 drivers/media/video/mt9m111.c Guennadi Liakhovetski 2009-08-25 546 :::::: The code at line 530 was first introduced by commit :::::: 49410d3abf4492d8be1e6ce6e8ece0e16407f22d media: mt9m111: make SUBDEV_G_FMT ioctl work with SUBDEV_FORMAT_TRY :::::: TO: Akinobu Mita <akinobu.mita@xxxxxxxxx> :::::: CC: Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
