Re: [PATCH] media: v4l2-tpg: Fix the memory layout of AYUV buffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le mardi 05 février 2019 à 15:38 +0100, Philipp Zabel a écrit :
> Hi Hans,
> 
> On Thu, 2019-01-31 at 14:36 +0100, Hans Verkuil wrote:
> [...]
> > Our YUV32 fourcc is defined as follows:
> > 
> > https://hverkuil.home.xs4all.nl/spec/uapi/v4l/pixfmt-packed-yuv.html
> > 
> > As far as I see the format that the TPG generates is according to the V4L2 spec.
> > 
> > Philipp, can you check the YUV32 format that the imx-pxp driver uses?
> > Is that according to our spec?
> > 
> > At some point we probably want to add a VUY32 format which is what Weston
> > expects, but we certainly cannot change what the TPG generates for YUV32
> > since that is correct.
> 
> I hadn't noticed as YUV32 doesn't show up in GStreamer, but testing with
> v4l2-ctl, it seems to be incorrect. This script:

Oops, noted, I have filed an issue for that.

https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/565

It was skipped because I always assumed this was not a real format. It
was added in GStreamer for software color conversion as a YUV unpack
format (same for AYUV64 16-16-16-16). This is used in the generic color
conversion path, or the slow path.

> 
>   #!/bin/sh
>   function check() {
>       PATTERN="$1"
>       NAME="$2"
>       echo -ne "${NAME}:\t"
>       v4l2-ctl \
>           --set-fmt-video-out=width=8,height=8,pixelformat=RGBP \
>           --set-fmt-video=width=8,height=8,pixelformat=YUV4 \
>           --stream-count 1 \
>           --stream-poll \
>           --stream-out-pattern "${PATTERN}" \
>           --stream-out-mmap 3 \
>           --stream-mmap 3 \
>           --stream-to - 2>/dev/null | hexdump -v -n4 -e '/1 "%02x "'
>       echo
>   }
>   check 6 "100% white"
>   check 7 "100% red"
>   check 9 "100% blue"
> 
> results in the following output:
> 
>   100% white:	80 80 ea ff 
>   100% red:	f0 66 3e ff 
>   100% blue:	74 f0 23 ff 
> 
> That looks like 32-bit VUYA 8-8-8-8.
> 
> regards
> Philipp




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux