On 2/5/19 3:38 PM, Philipp Zabel wrote: > Hi Hans, > > On Thu, 2019-01-31 at 14:36 +0100, Hans Verkuil wrote: > [...] >> >> Our YUV32 fourcc is defined as follows: >> >> https://hverkuil.home.xs4all.nl/spec/uapi/v4l/pixfmt-packed-yuv.html >> >> As far as I see the format that the TPG generates is according to the V4L2 spec. >> >> Philipp, can you check the YUV32 format that the imx-pxp driver uses? >> Is that according to our spec? >> >> At some point we probably want to add a VUY32 format which is what Weston >> expects, but we certainly cannot change what the TPG generates for YUV32 >> since that is correct. > > I hadn't noticed as YUV32 doesn't show up in GStreamer, but testing with > v4l2-ctl, it seems to be incorrect. This script: > > #!/bin/sh > function check() { > PATTERN="$1" > NAME="$2" > echo -ne "${NAME}:\t" > v4l2-ctl \ > --set-fmt-video-out=width=8,height=8,pixelformat=RGBP \ > --set-fmt-video=width=8,height=8,pixelformat=YUV4 \ > --stream-count 1 \ > --stream-poll \ > --stream-out-pattern "${PATTERN}" \ > --stream-out-mmap 3 \ > --stream-mmap 3 \ > --stream-to - 2>/dev/null | hexdump -v -n4 -e '/1 "%02x "' > echo > } > check 6 "100% white" > check 7 "100% red" > check 9 "100% blue" > > results in the following output: > > 100% white: 80 80 ea ff > 100% red: f0 66 3e ff > 100% blue: 74 f0 23 ff > > That looks like 32-bit VUYA 8-8-8-8. Right. So Vivek, can you make the patches to add a proper VUYA pixelformat? And a final patch updating imx-pxp so it uses the right pixelformat? Since there is now a driver using it, it is also not a problem anymore to get the new pixelformat patches merged. Regards, Hans
