Re: omap34xxcam question?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Aguirre, Sergio wrote:

-----Original Message-----
From: Michael Trimarchi [mailto:michael@xxxxxxxxxxxxxxxxxxxxxxx]
Sent: Thursday, January 14, 2010 6:01 AM
To: linux-media@xxxxxxxxxxxxxxx
Cc: Aguirre, Sergio
Subject: omap34xxcam question?

Hi

Is ok that it try only the first format and size? why does it not continue
and find a matching?

Actually, that was the intention, but I guess it was badly implemented.

Thanks for the catch, and the contribution!

Regards,
Sergio
@@ -470,7 +471,7 @@ static int try_pix_parm(struct omap34xxcam_videodev
*vdev,
                        pix_tmp_out = *wanted_pix_out;
                        rval = isp_try_fmt_cap(isp, &pix_tmp_in,
&pix_tmp_out);
                        if (rval)
-                               return rval;
+                               continue;


Is the patch good? or you are going to provide a better fix

Michael

Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux