On Sat, Feb 02, 2019 at 10:38:58AM +0100, Hans Verkuil wrote: > On 02/01/2019 02:51 PM, Sakari Ailus wrote: > > Add support for META_OUTPUT buffer type to v4l2-ctl. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > --- > > Hi Hans, others, > > > > I've reworked the patch to match with the way SDR is implemented: the > > options for setting the format work independently of the node type. > > > > I like this better than the previous one; there is much less redundant > > code now. > > > > utils/v4l2-ctl/v4l2-ctl-meta.cpp | 97 ++++++++++++++++++++++++++-------------- > > utils/v4l2-ctl/v4l2-ctl.cpp | 7 +++ > > utils/v4l2-ctl/v4l2-ctl.h | 5 +++ > > 3 files changed, 76 insertions(+), 33 deletions(-) > > > > diff --git a/utils/v4l2-ctl/v4l2-ctl-meta.cpp b/utils/v4l2-ctl/v4l2-ctl-meta.cpp > > <snip> > > > +void __meta_get(cv4l_fd &fd, __32 type) > > __32??? > > This clearly hasn't even been compile tested. > > I also saw a pile of compiler warnings elsewhere after applying this patch. > > I'm not sure what happened, perhaps an old version of the patch was accidentally > posted, but I'll wait for a v4. Oops. I fixed the problems you've seen but I ended up sending an older version. I'll send v4... -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
