Re: [PATCH] media: vb2: Fix compilation warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is already fixed in a pending pull request.

Hans

On February 1, 2019 3:51:35 PM GMT+01:00, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>Commit 2cc1802f62e5 removed code without removing a local variable that
>ended up being unused. This results in a compilation warning, fix it.
>
>Fixes: 2cc1802f62e5 ("media: vb2: Keep dma-buf buffers mapped until
>they are freed")
>Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>---
> drivers/media/common/videobuf2/videobuf2-core.c | 1 -
> 1 file changed, 1 deletion(-)
>
>I wonder how the offending commit got merged without the warning being
>noticed. Sakari, as a useful exercise, could you check whether this
>would have been caught by the automatic build system you're
>experimenting with ?
>
>diff --git a/drivers/media/common/videobuf2/videobuf2-core.c
>b/drivers/media/common/videobuf2/videobuf2-core.c
>index e07b6bdb6982..34cc87ca8d59 100644
>--- a/drivers/media/common/videobuf2/videobuf2-core.c
>+++ b/drivers/media/common/videobuf2/videobuf2-core.c
>@@ -1769,7 +1769,6 @@ EXPORT_SYMBOL_GPL(vb2_wait_for_all_buffers);
> static void __vb2_dqbuf(struct vb2_buffer *vb)
> {
> 	struct vb2_queue *q = vb->vb2_queue;
>-	unsigned int i;
> 
> 	/* nothing to do if the buffer is already dequeued */
> 	if (vb->state == VB2_BUF_STATE_DEQUEUED)

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux