El Miércoles, 13 de Enero de 2010, Jose Alberto Reguero escribió: > El Martes, 12 de Enero de 2010, Jose Alberto Reguero escribió: > > El Martes, 12 de Enero de 2010, Jean-Francois Moine escribió: > > > On Mon, 11 Jan 2010 15:49:55 +0100 > > > > > > Jose Alberto Reguero <jareguero@xxxxxxxxxxxxxx> wrote: > > > > I take another image with 640x480 and the bad bottom lines are 8. The > > > > right side look right this time. The good sizes are: > > > > 320x240->320x232 > > > > 640x480->640x472 > > > > > > Hi Jose Alberto and Hans, > > > > > > Hans, I modified a bit your patch to handle the 2 resolutions (also, > > > the problem with pas202b does not exist anymore). May you sign or ack > > > it? > > > > > > Jose Alberto, the attached patch is to be applied to the last version > > > of the gspca in my test repository at LinuxTv.org > > > http://linuxtv.org/hg/~jfrancois/gspca > > > May you try it? > > > > > > Regards. > > > > The patch works well. > > There is another problem. When autogain is on(default), the image is bad. > > It is possible to put autogain off by default? > > > > Thanks. > > Jose Alberto > > Autogain works well again. I can't reproduce the problem. Perhaps the debug > messages. (Now I have debug off). > > Thanks. > Jose Alberto I found the problem. Autogain don't work well if brightness is de default value(128). if brightness is less(64) autogain work well. There is a problem when setting the brightness. It is safe to remove the brightness control? Patch attached. Jose Alberto
diff -r d490d84a64ac linux/drivers/media/video/gspca/zc3xx.c --- a/linux/drivers/media/video/gspca/zc3xx.c Wed Jan 13 12:11:34 2010 -0200 +++ b/linux/drivers/media/video/gspca/zc3xx.c Thu Jan 14 17:03:10 2010 +0100 @@ -6028,6 +6041,7 @@ case SENSOR_OV7620: case SENSOR_PAS202B: case SENSOR_PO2030: + case SENSOR_MC501CB: return; } /*fixme: is it really write to 011d and 018d for all other sensors? */ @@ -6796,6 +6837,7 @@ case SENSOR_OV7620: case SENSOR_PAS202B: case SENSOR_PO2030: + case SENSOR_MC501CB: gspca_dev->ctrl_dis = (1 << BRIGHTNESS_IDX); break; case SENSOR_HV7131B:
