Re: [PATCH v2 2/2] media: ipu3-imgu: Remove dead code for NULL check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yong,

On Wed, Jan 16, 2019 at 09:18:47AM -0800, Yong Zhi wrote:
> Since ipu3_css_buf_dequeue() never returns NULL, remove the
> dead code to fix static checker warning:
> 
> drivers/staging/media/ipu3/ipu3.c:493 imgu_isr_threaded()
> warn: 'b' is an error pointer or valid
> 
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> [Bug report: https://lore.kernel.org/linux-media/20190104122856.GA1169@kadam/]
> Signed-off-by: Yong Zhi <yong.zhi@xxxxxxxxx>
> Reviewed-by: Tomasz Figa <tfiga@xxxxxxxxxxxx>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

I don't see Laurent's Reviewed-by: tag on the list. Did you get that from
him off-list? If he hasn't given one, please send v3 without that tag.

Thanks.

-- 
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux