Re: drivers/media/platform/imx-pxp.c:683: possible cut''n'paste error ?

[Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>]

On Sun, 2019-01-27 at 08:17 +0000, David Binderman wrote:
> Hello there,
> 
> drivers/media/platform/imx-pxp.c:683:24: warning: duplicated ‘if’ condition [-Wd
> uplicated-cond]
> 
> Source code is
> 
>                } else if (ycbcr_enc == V4L2_YCBCR_ENC_709) {
>                         if (quantization == V4L2_QUANTIZATION_FULL_RANGE)
>                                 csc2_coef = csc2_coef_rec709_full;
>                         else
>                                 csc2_coef = csc2_coef_rec709_lim;
>                 } else if (ycbcr_enc == V4L2_YCBCR_ENC_709) {
>                         if (quantization == V4L2_QUANTIZATION_FULL_RANGE)
>                                 csc2_coef = csc2_coef_bt2020_full;
>                         else
>                                 csc2_coef = csc2_coef_bt2020_lim;
>                 } else {
> 
> The condition on the second if looks wrong. Suggest code rework.

Thank you, I have sent a patch.

regards
Philipp